possible error with shock_decomposition in dynare 4.2.0

This forum is closed. You can read the posts but cannot write. We have migrated the forum to a new location where you will have to reset your password.
Forum rules
This forum is closed. You can read the posts but cannot write. We have migrated the forum to a new location (https://forum.dynare.org) where you will have to reset your password.

possible error with shock_decomposition in dynare 4.2.0

Postby pathiggins76 » Tue Feb 22, 2011 8:41 pm

Hi, I may have found an error in the function evaluate_smoother.m, which is called by shock_decomposition.m. Lines 146-147 of evaluate_smoother.m are

[atT,innov,measurement_error,updated_variables,ys,trend_coeff,aK,T,R,P,PK,decomp] ...
= DsgeSmoother(parameters,gend,data,data_index,number_of_observations);

I think the last argument is wrong and instead should be missing_value (0/1 dummy for whether data has missing observations) instead of number_of_observations. That is the code should be

[atT,innov,measurement_error,updated_variables,ys,trend_coeff,aK,T,R,P,PK,decomp] ...
= DsgeSmoother(parameters,gend,data,data_index,missing_value);

dynare_estimation_1 calls DsgeSmoother several times as well and the last argument is missing_value. DsgeSmoother.m also looks like it expects missing_value as its last argument. Thanks a lot.

-Pat
pathiggins76
 
Posts: 1
Joined: Tue Feb 22, 2011 8:26 pm

Re: possible error with shock_decomposition in dynare 4.2.0

Postby SébastienVillemot » Wed Feb 23, 2011 9:18 am

Thanks for reporting this. It will be fixed in the next release.
Sébastien Villemot
Economist at OFCE – Sciences Po
SébastienVillemot
 
Posts: 706
Joined: Fri Dec 07, 2007 2:29 pm
Location: Paris, France

Re: possible error with shock_decomposition in dynare 4.2.0

Postby elchinomilton » Wed Mar 16, 2011 2:12 am

Hi there,

I was looking for a post on missing observations and saw this one so maybe one of you can help me with two basic questions:

1) How do I need to declare a missing observation in the data file? Is it an empty cell or some type of a character (such as "." for example)?
2) Do I need to change anything in the estimation command to alert the program that there are missing observations?

Thanks in advance!

El Chino Milton
elchinomilton
 
Posts: 2
Joined: Wed Mar 16, 2011 2:04 am


Return to Dynare help

Who is online

Users browsing this forum: Google [Bot] and 8 guests